Packages
credo
1.7.2-rc.2
1.7.19
1.7.18
1.7.17
1.7.16
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.7-rc.0
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.2-rc.4
1.7.2-rc.3
1.7.2-rc.2
1.7.2-rc.1
1.7.2-rc.0
1.7.1
1.7.0
1.7.0-rc.2
1.7.0-rc.1
1.6.7
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.6.0-rc.1
1.6.0-rc.0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.5.0-rc.5
1.5.0-rc.4
1.5.0-rc.3
1.5.0-rc.2
1.5.0-rc.1
1.4.1
1.4.0
1.4.0-rc.2
1.4.0-rc.1
1.3.2
1.3.1
1.3.0
1.3.0-rc3
1.3.0-rc2
1.3.0-rc1
1.2.3
1.2.2
1.2.1
1.2.0
1.2.0-rc4
1.2.0-rc3
1.2.0-rc2
1.2.0-rc1
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.1.0-rc3
1.1.0-rc2
1.1.0-rc1
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.1-rc1
1.0.0
1.0.0-rc1
0.10.2
0.10.1
0.10.0
0.9.3
0.9.2
0.9.1
0.9.0
0.9.0-rc8
0.9.0-rc7
0.9.0-rc6
0.9.0-rc5
0.9.0-rc4
0.9.0-rc3
0.9.0-rc2
0.9.0-rc1
0.8.10
0.8.9
0.8.8
0.8.7
0.8.6
0.8.5
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.8.0-rc7
0.8.0-rc6
0.8.0-rc5
0.8.0-rc4
0.8.0-rc3
0.8.0-rc2
0.8.0-rc1
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.1
0.6.0
0.6.0-rc2
0.6.0-rc1
0.5.3
0.5.2
0.5.1
0.5.0
0.4.14
0.4.13
0.4.12
0.4.11
0.4.10
0.4.10-dev
0.4.9
0.4.8
0.4.7
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.4.0-beta5
0.4.0-beta4
0.4.0-beta3
0.4.0-beta2
0.4.0-beta1
0.3.13
0.3.12
0.3.11
0.3.10
0.3.9
0.3.8
0.3.7
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.3.0-dev2
0.3.0-dev
0.2.6
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.10
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.1-dev
A static code analysis tool with a focus on code consistency and teaching.
Current section
Files
Jump to
Current section
Files
lib/credo/check/readability/single_function_to_block_pipe.ex
defmodule Credo.Check.Readability.SingleFunctionToBlockPipe do
use Credo.Check,
id: "EX3022",
tags: [:controversial],
explanations: [
check: """
A single pipe (`|>`) should not be used to pipe into blocks.
The code in this example ...
list
|> length()
|> case do
0 -> :none
1 -> :one
_ -> :many
end
... should be refactored to look like this:
case length(list) do
0 -> :none
1 -> :one
_ -> :many
end
If you want to disallow piping into blocks all together, use
`Credo.Check.Readability.BlockPipe`.
"""
]
@doc false
@impl true
def run(%SourceFile{} = source_file, params) do
Credo.Code.prewalk(source_file, &traverse(&1, &2, IssueMeta.for(source_file, params)))
end
defp traverse(ast, {false, issues}, _issue_meta) do
{ast, issues}
end
defp traverse(ast, issues, issue_meta) do
case issue(ast, issue_meta) do
nil -> {ast, issues}
false -> {ast, {false, issues}}
issue -> {ast, [issue | issues]}
end
end
defp issue({:|>, _, [{:|>, _, [{:|>, _, _} | _]} | _]}, _), do: false
defp issue({:|>, meta, [arg, {marker, _case_meta, _case_args}]}, issue_meta)
when marker in [:case, :if] do
if issue?(arg), do: issue_for(issue_meta, meta[:line]), else: nil
end
defp issue(_, _), do: nil
defp issue?({_, _, nil}), do: true
defp issue?({:%{}, _, _}), do: true
defp issue?(arg) when is_list(arg), do: true
defp issue?({:|>, _, [{_, _, nil}, {_, _, args}]}) when is_list(args), do: true
defp issue?({:|>, _, [{:%{}, _, _}, {_, _, args}]}) when is_list(args), do: true
defp issue?({:|>, _, [arg, {_, _, args}]}) when is_list(arg) and is_list(args), do: true
defp issue?(_), do: false
defp issue_for(issue_meta, line_no) do
format_issue(
issue_meta,
message: "Avoid single pipes to a block",
line_no: line_no
)
end
end