Packages
credo
1.7.15
1.7.19
1.7.18
1.7.17
1.7.16
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.7-rc.0
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.2-rc.4
1.7.2-rc.3
1.7.2-rc.2
1.7.2-rc.1
1.7.2-rc.0
1.7.1
1.7.0
1.7.0-rc.2
1.7.0-rc.1
1.6.7
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.6.0-rc.1
1.6.0-rc.0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.5.0-rc.5
1.5.0-rc.4
1.5.0-rc.3
1.5.0-rc.2
1.5.0-rc.1
1.4.1
1.4.0
1.4.0-rc.2
1.4.0-rc.1
1.3.2
1.3.1
1.3.0
1.3.0-rc3
1.3.0-rc2
1.3.0-rc1
1.2.3
1.2.2
1.2.1
1.2.0
1.2.0-rc4
1.2.0-rc3
1.2.0-rc2
1.2.0-rc1
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.1.0-rc3
1.1.0-rc2
1.1.0-rc1
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.1-rc1
1.0.0
1.0.0-rc1
0.10.2
0.10.1
0.10.0
0.9.3
0.9.2
0.9.1
0.9.0
0.9.0-rc8
0.9.0-rc7
0.9.0-rc6
0.9.0-rc5
0.9.0-rc4
0.9.0-rc3
0.9.0-rc2
0.9.0-rc1
0.8.10
0.8.9
0.8.8
0.8.7
0.8.6
0.8.5
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.8.0-rc7
0.8.0-rc6
0.8.0-rc5
0.8.0-rc4
0.8.0-rc3
0.8.0-rc2
0.8.0-rc1
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.1
0.6.0
0.6.0-rc2
0.6.0-rc1
0.5.3
0.5.2
0.5.1
0.5.0
0.4.14
0.4.13
0.4.12
0.4.11
0.4.10
0.4.10-dev
0.4.9
0.4.8
0.4.7
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.4.0-beta5
0.4.0-beta4
0.4.0-beta3
0.4.0-beta2
0.4.0-beta1
0.3.13
0.3.12
0.3.11
0.3.10
0.3.9
0.3.8
0.3.7
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.3.0-dev2
0.3.0-dev
0.2.6
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.10
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.1-dev
A static code analysis tool with a focus on code consistency and teaching.
Current section
Files
Jump to
Current section
Files
lib/credo/check/warning/bool_operation_on_same_values.ex
defmodule Credo.Check.Warning.BoolOperationOnSameValues do
use Credo.Check,
id: "EX5002",
base_priority: :high,
explanations: [
check: """
Boolean operations with identical values on the left and right side are
most probably a logical fallacy or a copy-and-paste error.
Examples:
x && x
x || x
x and x
x or x
Each of these cases behaves the same as if you were just writing `x`.
"""
]
@bool_ops [:and, :or, :&&, :||]
@doc false
@impl true
def run(%SourceFile{} = source_file, params) do
ctx = Context.build(source_file, params, __MODULE__)
result = Credo.Code.prewalk(source_file, &walk/2, ctx)
result.issues
end
defp walk({:defmodule, _meta, _} = ast, ctx) do
redefined_ops = Credo.Code.prewalk(ast, &find_bool_op_redefinition(&1, &2))
ctx = Map.merge(ctx, %{redefined_ops: redefined_ops})
{ast, Credo.Code.prewalk(ast, &walk_module/2, ctx)}
end
defp walk(ast, ctx) do
{ast, ctx}
end
for op <- @bool_ops do
defp walk_module({unquote(op), meta, [lhs, rhs]} = ast, ctx) do
op_not_redefined? = unquote(op) not in ctx.redefined_ops
if op_not_redefined? && Credo.Code.remove_metadata(lhs) === Credo.Code.remove_metadata(rhs) do
{ast, put_issue(ctx, issue_for(ctx, meta, unquote(op)))}
else
{ast, ctx}
end
end
end
defp walk_module(ast, ctx) do
{ast, ctx}
end
for op <- @bool_ops do
defp find_bool_op_redefinition({:def, _, [{unquote(op), _, [_ | _]}, [_ | _]]} = ast, acc) do
{ast, acc ++ [unquote(op)]}
end
defp find_bool_op_redefinition(
{:def, _, [{:when, _, [{unquote(op), _, _} | _]} | _]} = ast,
acc
) do
{ast, acc ++ [unquote(op)]}
end
end
defp find_bool_op_redefinition(ast, acc) do
{ast, acc}
end
defp issue_for(issue_meta, meta, trigger) do
format_issue(
issue_meta,
message:
"There are identical sub-expressions to the left and to the right of the '#{trigger}' operator.",
trigger: trigger,
line_no: meta[:line],
column: meta[:column]
)
end
end