Current section

Files

Jump to
credo lib credo check readability function_names.ex
Raw

lib/credo/check/readability/function_names.ex

defmodule Credo.Check.Readability.FunctionNames do
@moduledoc false
@checkdoc """
Function and macro names are always written in snake_case in Elixir.
# snake_case
def handle_incoming_message(message) do
end
# not snake_case
def handleIncomingMessage(message) do
end
Like all `Readability` issues, this one is not a technical concern.
But you can improve the odds of others reading and liking your code by making
it easier to follow.
"""
@explanation [check: @checkdoc]
@def_ops [:def, :defp, :defmacro]
use Credo.Check, base_priority: :high
alias Credo.Code.Name
@doc false
def run(%SourceFile{} = source_file, params \\ []) do
issue_meta = IssueMeta.for(source_file, params)
Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
end
for op <- @def_ops do
# catch variables named e.g. `defp`
defp traverse({unquote(op), _meta, nil} = ast, issues, _issue_meta) do
{ast, issues}
end
defp traverse({unquote(op), _meta, arguments} = ast, issues, issue_meta) do
{ast, issues_for_definition(arguments, issues, issue_meta)}
end
end
defp traverse(ast, issues, _issue_meta) do
{ast, issues}
end
defp issues_for_definition(body, issues, issue_meta) do
case Enum.at(body, 0) do
{name, meta, nil} ->
issues_for_name(name, meta, issues, issue_meta)
_ ->
issues
end
end
def issues_for_name(name, meta, issues, issue_meta) do
if name |> to_string |> Name.snake_case?() do
issues
else
[issue_for(issue_meta, meta[:line], name) | issues]
end
end
defp issue_for(issue_meta, line_no, trigger) do
format_issue(
issue_meta,
message: "Function/macro names should be written in snake_case.",
trigger: trigger,
line_no: line_no
)
end
end