Packages
credo
0.9.1
1.7.19
1.7.18
1.7.17
1.7.16
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.7-rc.0
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.2-rc.4
1.7.2-rc.3
1.7.2-rc.2
1.7.2-rc.1
1.7.2-rc.0
1.7.1
1.7.0
1.7.0-rc.2
1.7.0-rc.1
1.6.7
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.6.0-rc.1
1.6.0-rc.0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.5.0-rc.5
1.5.0-rc.4
1.5.0-rc.3
1.5.0-rc.2
1.5.0-rc.1
1.4.1
1.4.0
1.4.0-rc.2
1.4.0-rc.1
1.3.2
1.3.1
1.3.0
1.3.0-rc3
1.3.0-rc2
1.3.0-rc1
1.2.3
1.2.2
1.2.1
1.2.0
1.2.0-rc4
1.2.0-rc3
1.2.0-rc2
1.2.0-rc1
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.1.0-rc3
1.1.0-rc2
1.1.0-rc1
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.1-rc1
1.0.0
1.0.0-rc1
0.10.2
0.10.1
0.10.0
0.9.3
0.9.2
0.9.1
0.9.0
0.9.0-rc8
0.9.0-rc7
0.9.0-rc6
0.9.0-rc5
0.9.0-rc4
0.9.0-rc3
0.9.0-rc2
0.9.0-rc1
0.8.10
0.8.9
0.8.8
0.8.7
0.8.6
0.8.5
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.8.0-rc7
0.8.0-rc6
0.8.0-rc5
0.8.0-rc4
0.8.0-rc3
0.8.0-rc2
0.8.0-rc1
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.1
0.6.0
0.6.0-rc2
0.6.0-rc1
0.5.3
0.5.2
0.5.1
0.5.0
0.4.14
0.4.13
0.4.12
0.4.11
0.4.10
0.4.10-dev
0.4.9
0.4.8
0.4.7
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.4.0-beta5
0.4.0-beta4
0.4.0-beta3
0.4.0-beta2
0.4.0-beta1
0.3.13
0.3.12
0.3.11
0.3.10
0.3.9
0.3.8
0.3.7
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.3.0-dev2
0.3.0-dev
0.2.6
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.10
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.1-dev
A static code analysis tool with a focus on code consistency and teaching.
Current section
Files
Jump to
Current section
Files
lib/credo/check/warning/operation_on_same_values.ex
defmodule Credo.Check.Warning.OperationOnSameValues do
@moduledoc """
Operations on the same values always yield the same result and therefore make
little sense in production code.
Examples:
x == x # always returns true
x <= x # always returns true
x >= x # always returns true
x != x # always returns false
x > x # always returns false
y / y # always returns 1
y - y # always returns 0
In practice they are likely the result of a debugging session or were made by
mistake.
"""
@explanation [check: @moduledoc]
@def_ops [:def, :defp, :defmacro]
@ops ~w(== >= <= != > < / -)a
@ops_and_constant_results [
{:==, "Comparison", true},
{:>=, "Comparison", true},
{:<=, "Comparison", true},
{:!=, "Comparison", false},
{:>, "Comparison", false},
{:<, "Comparison", false},
{:/, "Operation", 1},
{:-, "Operation", 0}
]
use Credo.Check, base_priority: :high
@doc false
def run(source_file, params \\ []) do
issue_meta = IssueMeta.for(source_file, params)
Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
end
for op <- @def_ops do
# exclude def arguments for operators
defp traverse(
{unquote(op), _meta, [{op, _, _} | rest]},
issues,
_issue_meta
)
when op in @ops do
{rest, issues}
end
end
for {op, operation_name, constant_result} <- @ops_and_constant_results do
defp traverse({unquote(op), meta, [lhs, rhs]} = ast, issues, issue_meta) do
if CodeHelper.remove_metadata(lhs) == CodeHelper.remove_metadata(rhs) do
new_issue =
issue_for(
issue_meta,
meta[:line],
unquote(op),
unquote(operation_name),
unquote(constant_result)
)
{ast, issues ++ [new_issue]}
else
{ast, issues}
end
end
end
# exclude @spec definitions
defp traverse({:@, _meta, [{:spec, _, _} | _]}, issues, _issue_meta) do
{nil, issues}
end
defp traverse(ast, issues, _issue_meta) do
{ast, issues}
end
defp issue_for(issue_meta, line_no, trigger, operation, constant_result) do
format_issue(
issue_meta,
message: "#{operation} will always return #{constant_result}.",
trigger: trigger,
line_no: line_no
)
end
end