Current section

48 Versions

Jump to

Compare versions

13 files changed
+111 additions
-216 deletions
  @@ -1,5 +1,12 @@
1 1 # Changelog
2 2
3 + ## 0.7.2
4 +
5 + ### Changes
6 +
7 + - Fixes support for Ash 3. Thanks @ademenev!
8 + - Internal improvements
9 +
3 10 ## 0.7.1
4 11
5 12 ### Changes
  @@ -1,7 +1,7 @@
1 1 {<<"links">>,
2 2 [{<<"GitHub">>,<<"https://github.com/ArthurClemens/primer_live">>}]}.
3 3 {<<"name">>,<<"primer_live">>}.
4 - {<<"version">>,<<"0.7.1">>}.
4 + {<<"version">>,<<"0.7.2">>}.
5 5 {<<"description">>,
6 6 <<"An implementation of GitHub's Primer Design System for Phoenix LiveView.">>}.
7 7 {<<"app">>,<<"primer_live">>}.
  @@ -10,8 +10,7 @@
10 10 [<<"lib">>,<<"lib/field_state.ex">>,<<"lib/component.ex">>,<<"lib/theme">>,
11 11 <<"lib/theme/theme.ex">>,<<"lib/primer_live.ex">>,<<"lib/helpers">>,
12 12 <<"lib/helpers/form_helpers.ex">>,<<"lib/helpers/attribute_helpers.ex">>,
13 - <<"lib/helpers/octicons_helper.ex">>,<<"lib/helpers/schema_helpers.ex">>,
14 - <<"lib/helpers/component_helpers.ex">>,
13 + <<"lib/helpers/schema_helpers.ex">>,<<"lib/helpers/component_helpers.ex">>,
15 14 <<"lib/helpers/declaration_helpers.ex">>,
16 15 <<"lib/helpers/prompt_declaration_helpers.ex">>,<<"lib/ui_icons.ex">>,
17 16 <<"lib/octicons.ex">>,<<".formatter.exs">>,<<"mix.exs">>,<<"README.md">>,
unknownlib/component.ex
File is too large to be displayed (100 KB limit).
  @@ -189,11 +189,9 @@ defmodule PrimerLive.Helpers.AttributeHelpers do
189 189 def as_integer(input, _default_value) when is_float(input), do: trunc(input)
190 190
191 191 def as_integer(input, default_value) when is_binary(input) do
192 - try do
193 - String.to_integer(input)
194 - rescue
195 - ArgumentError -> default_value
196 - end
192 + String.to_integer(input)
193 + rescue
194 + ArgumentError -> default_value
197 195 end
198 196
199 197 def as_integer(_input, default_value), do: default_value
  @@ -378,19 +376,19 @@ defmodule PrimerLive.Helpers.AttributeHelpers do
378 376
379 377 ## Tests
380 378
381 - iex> PrimerLive.Helpers.AttributeHelpers.is_link?(%{href: "#url"})
379 + iex> PrimerLive.Helpers.AttributeHelpers.link?(%{href: "#url"})
382 380 true
383 381
384 - iex> PrimerLive.Helpers.AttributeHelpers.is_link?(%{navigate: "#url"})
382 + iex> PrimerLive.Helpers.AttributeHelpers.link?(%{navigate: "#url"})
385 383 true
386 384
387 - iex> PrimerLive.Helpers.AttributeHelpers.is_link?(%{patch: "#url"})
385 + iex> PrimerLive.Helpers.AttributeHelpers.link?(%{patch: "#url"})
388 386 true
389 387
390 - iex> PrimerLive.Helpers.AttributeHelpers.is_link?(%{url: "#url"})
388 + iex> PrimerLive.Helpers.AttributeHelpers.link?(%{url: "#url"})
391 389 false
392 390 """
393 - def is_link?(assigns), do: !!link_url(assigns)
391 + def link?(assigns), do: !!link_url(assigns)
394 392
395 393 defp link_url(assigns), do: assigns[:href] || assigns[:navigate] || assigns[:patch]
396 394
  @@ -399,25 +397,25 @@ defmodule PrimerLive.Helpers.AttributeHelpers do
399 397
400 398 ## Tests
401 399
402 - iex> PrimerLive.Helpers.AttributeHelpers.is_anchor_link?(%{})
400 + iex> PrimerLive.Helpers.AttributeHelpers.anchor_link?(%{})
403 401 false
404 402
405 - iex> PrimerLive.Helpers.AttributeHelpers.is_anchor_link?(%{href: "/url"})
403 + iex> PrimerLive.Helpers.AttributeHelpers.anchor_link?(%{href: "/url"})
406 404 false
407 405
408 - iex> PrimerLive.Helpers.AttributeHelpers.is_anchor_link?(%{href: "url"})
406 + iex> PrimerLive.Helpers.AttributeHelpers.anchor_link?(%{href: "url"})
409 407 false
410 408
411 - iex> PrimerLive.Helpers.AttributeHelpers.is_anchor_link?(%{href: "#url"})
409 + iex> PrimerLive.Helpers.AttributeHelpers.anchor_link?(%{href: "#url"})
412 410 true
413 411 """
414 - def is_anchor_link?(assigns) do
415 - link_url(assigns) |> is_anchor_link_url?()
412 + def anchor_link?(assigns) do
413 + link_url(assigns) |> anchor_link_url?()
416 414 end
417 415
418 - defp is_anchor_link_url?(url) when is_nil(url), do: false
416 + defp anchor_link_url?(url) when is_nil(url), do: false
419 417
420 - defp is_anchor_link_url?(url) do
418 + defp anchor_link_url?(url) do
421 419 String.match?(url, ~r/^#/)
422 420 end
  @@ -33,13 +33,13 @@ defmodule PrimerLive.Helpers.ComponentHelpers do
33 33 end
34 34 end
35 35
36 - defp has_slot_content(rendered), do: !is_empty_slot(rendered)
37 - defp is_empty_slot(rendered) when is_nil(rendered), do: false
38 - defp is_empty_slot(rendered), do: is_empty_slot_content(rendered.static)
39 - defp is_empty_slot_content(static) when is_nil(static), do: true
40 - defp is_empty_slot_content(static) when static == [""], do: true
36 + defp has_slot_content(rendered), do: !empty_slot?(rendered)
37 + defp empty_slot?(rendered) when is_nil(rendered), do: false
38 + defp empty_slot?(rendered), do: empty_slot_content?(rendered.static)
39 + defp empty_slot_content?(static) when is_nil(static), do: true
40 + defp empty_slot_content?(static) when static == [""], do: true
41 41
42 - defp is_empty_slot_content(static) do
42 + defp empty_slot_content?(static) do
43 43 cond do
44 44 static == [] -> true
45 45 hd(static) |> String.trim() == "" -> true
Loading more files…